Benjamin Otte [Mon, 24 Feb 2014 13:17:28 +0000 (14:17 +0100)]
a11y: Split out creation of cell info
Don't mix cell info creation with cell accessible creation. Instead,
first create the accessible, then create the cell info.
Benjamin Otte [Mon, 24 Feb 2014 13:07:57 +0000 (14:07 +0100)]
a11y: Split out a function
First in a set of refactorings to make the create_cell() function
actually understandable.
Giovanni Campagna [Tue, 25 Feb 2014 23:02:04 +0000 (00:02 +0100)]
Gdk: fix wrong user_data handling in resize_cairo_surface()
Instead of destroying the surface in the backend if this is
unable to resize, let the core code do it, and do it properly.
Based on a patch by Benjamin Otte.
https://bugzilla.gnome.org/show_bug.cgi?id=725172
Giovanni Campagna [Tue, 25 Feb 2014 21:18:28 +0000 (22:18 +0100)]
pixbuf-demo: don't lock the window size
What's the use of an animation demo, if you can interactively
resize it and show off how cool is your window system handling
updates?
https://bugzilla.gnome.org/show_bug.cgi?id=725172
Chun-wei Fan [Tue, 25 Feb 2014 05:32:13 +0000 (13:32 +0800)]
MSVC Builds: Update Introspection Build Process
GObject-Introspection was recently changed to support acquiring the name of
the DLL from a library (.lib, etc) that was passed into g-ir-scanner on
Windows, like the *nix builds, instead of directly passing in the name of
the DLL.
This updates the introspection build process, so that introspection files
for GTK+ can continue to be properly built.
Jasper St. Pierre [Sun, 23 Feb 2014 21:06:05 +0000 (16:06 -0500)]
Add gtkactionbar.ui.h
Jasper St. Pierre [Sun, 23 Feb 2014 21:06:20 +0000 (16:06 -0500)]
wayland: Don't destroy the cairo surface when resizing it
The code in GDK is incredibly broken and nobody is quite sure what's
right-side-up and what's upside down, but this breaks mutter-wayland
now, so let's remove it. It might leak, but we should probably do a
full restructuring of GDK drawing to fix it.
Benjamin Otte [Sun, 23 Feb 2014 19:00:08 +0000 (20:00 +0100)]
toolpalette: Remove unused function
Rui Matos [Sat, 22 Feb 2014 18:10:59 +0000 (19:10 +0100)]
wayland: Fix gdk_window_wayland_resize_cairo_surface()
Like in other backends (except X) we can't resize cairo image surfaces
so let's sync the code here with what the other backends do.
This prevents the painting machinery above us to paint on the wrong
buffer.
https://bugzilla.gnome.org/show_bug.cgi?id=724968
Piotr Drąg [Sun, 23 Feb 2014 16:58:39 +0000 (17:58 +0100)]
Updated POTFILES.skip
Benjamin Otte [Sun, 23 Feb 2014 14:40:09 +0000 (15:40 +0100)]
testsuite: Don't leak in test runner
Benjamin Otte [Sun, 23 Feb 2014 14:39:36 +0000 (15:39 +0100)]
reftests: Add reftest for last commit
https://bugzilla.gnome.org/show_bug.cgi?id=724999
Benjamin Otte [Sun, 23 Feb 2014 13:57:44 +0000 (14:57 +0100)]
revealer: Pass correct size to child hfw function
The refactoring in
b9e37f8d2d4d14d3cb23f56a795fcdd2e6128e88 broke this.
https://bugzilla.gnome.org/show_bug.cgi?id=724999
Benjamin Otte [Fri, 21 Feb 2014 20:54:40 +0000 (21:54 +0100)]
csskeyframes: Split new() into alloc() and new()
The new() function is supposed to return an empty fully initialized
GtkCssKeyframes object, while the alloc() function just allocates and
initializes static values. So alloc() can be used for copying or
resolving keyframes.
Fixes a memleak when resolving keyframes.
GunChleoc [Sun, 23 Feb 2014 14:02:58 +0000 (14:02 +0000)]
Updated Scottish Gaelic translation
Matthias Clasen [Sun, 23 Feb 2014 02:42:05 +0000 (21:42 -0500)]
Be more careful to change state atomically
This avoids temporary states of maximized+tiled that
we otherwise report.
Wylmer Wang [Sun, 23 Feb 2014 02:00:31 +0000 (02:00 +0000)]
Updated Chinese (China) translation
Matthias Clasen [Sat, 22 Feb 2014 20:17:58 +0000 (15:17 -0500)]
Make testpopover more versatile
Allow testing alignment and positioning.
Matthias Clasen [Sat, 22 Feb 2014 19:07:48 +0000 (14:07 -0500)]
Take shadow size into account when positioning popovers
Without this, popovers have a tendency to protrude into the
invisible border of windows, which looks less than optimal.
Matthias Clasen [Sat, 22 Feb 2014 17:51:11 +0000 (12:51 -0500)]
a11y tests: Add a tests for menu buttons with popovers
This shows that popovers currently lack accessibility.
Matthias Clasen [Sat, 22 Feb 2014 17:49:24 +0000 (12:49 -0500)]
menu button: avoid property order dependencies
With the code as written, use-popover has to be set first,
before the model. To avoid this ordering dependency, re-set
the model when use-popover changes.
Matthias Clasen [Sat, 22 Feb 2014 17:36:55 +0000 (12:36 -0500)]
menu button: Fix property notification
Matthias Clasen [Sat, 22 Feb 2014 17:13:21 +0000 (12:13 -0500)]
a11y tests: Add a test for menubuttons with model
Matthias Clasen [Sat, 22 Feb 2014 17:08:45 +0000 (12:08 -0500)]
GtkModelButton: fix up naming
The convention we follow is that the PROP_foo define should
match the property name. Therefore, change PROP_MODEL to
PROP_MENU_MODEL to match "menu-model".
Matthias Clasen [Sat, 22 Feb 2014 17:02:30 +0000 (12:02 -0500)]
a11y tests: Add a test for GtkActionBar
Matthias Clasen [Sat, 22 Feb 2014 16:54:48 +0000 (11:54 -0500)]
a11y tests: add image buttons
Baurzhan Muftakhidinov [Sat, 22 Feb 2014 09:55:20 +0000 (09:55 +0000)]
Updated Kazakh translation
Matthias Clasen [Sat, 22 Feb 2014 03:31:16 +0000 (22:31 -0500)]
Fix life-cycle handling of treeview columns
gtk_tree_view_remove_column was first removing the column from
its list, then call gtk_tree_view_column_unset_tree_view, which
would then call gtk_container_remove to remove its button from
the treeview. But the treeview remove implementation relied
on the column being still in the list in order to recognize
the button as 'special', so in effect the button was never
properly removed and thus, leaked.
Fix this by callling unset_tree_view before removing the
column from the list.
https://bugzilla.gnome.org/show_bug.cgi?id=724891
Matthias Clasen [Sat, 22 Feb 2014 03:08:00 +0000 (22:08 -0500)]
Fix popover life-cycle handling
c28784524016b2a8eac18d5046ebc8cdaca7f9b0 was trying to fix
the memory leak caused by popovers begin destroyed in
gtk_window_destroy before chaining up to gtk_widget_destroy,
which unrealizes the window, and would clean up the popover
windows if the popovers were still around.
Fix this in a better way by moving the popover destruction
after the chaining up, so we unrealize first, and then
destroy the popovers.
Also, make _gtk_window_remove_popover unrealize the popover,
for symmetry with _gtk_window_add_popover.
This should fix
https://bugzilla.gnome.org/show_bug.cgi?id=724921
Matthias Clasen [Sat, 22 Feb 2014 02:40:48 +0000 (21:40 -0500)]
Fix GtkMenuToolButton
The addition of popovers to menu buttons broke this, by making
the toolbuttons stay insensitive.
https://bugzilla.gnome.org/show_bug.cgi?id=724799
Matthias Clasen [Sat, 22 Feb 2014 02:15:52 +0000 (21:15 -0500)]
about dialog: protect against gtk_widget_show_all
Normally, a GtkAboutDialog is shown using the convenience
API. But if you manually construct one and show it by calling
gtk_widget_show_all() on it, the license tab would show up
uninvited. Fix that.
https://bugzilla.gnome.org/show_bug.cgi?id=724411
Piotr Drąg [Sat, 22 Feb 2014 00:09:28 +0000 (01:09 +0100)]
Updated POTFILES.skip
Aurimas Černius [Fri, 21 Feb 2014 20:56:07 +0000 (22:56 +0200)]
Updated Lithuanian translation
William Jon McCann [Fri, 21 Feb 2014 20:13:17 +0000 (15:13 -0500)]
Don't leak the theme name
Paolo Borelli [Fri, 21 Feb 2014 20:07:11 +0000 (21:07 +0100)]
Do not leak cairo_region
William Jon McCann [Fri, 21 Feb 2014 19:02:37 +0000 (14:02 -0500)]
Don't leak the queried file info
https://bugzilla.gnome.org/show_bug.cgi?id=554618
William Jon McCann [Fri, 21 Feb 2014 18:43:55 +0000 (13:43 -0500)]
Unregister the popover before destroying it
Fixes a leak of the registered_windows list in GtkWidget.
https://bugzilla.gnome.org/show_bug.cgi?id=554618
Baurzhan Muftakhidinov [Fri, 21 Feb 2014 17:36:38 +0000 (17:36 +0000)]
Updated Kazakh translation
Marek Kasik [Fri, 21 Feb 2014 14:47:03 +0000 (15:47 +0100)]
printing: Fix visibility of tabs in print dialog
"Job", "Image Quality", "Color", "Finishing" and "Advanced" tabs
shouldn't be shown if there is no printer selected.
https://bugzilla.gnome.org/show_bug.cgi?id=724895
Marek Kasik [Fri, 21 Feb 2014 14:39:05 +0000 (15:39 +0100)]
printing: Fix sensitivity of the Print button
Don't make Print button sensitive until a printer is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=724895
Chun-wei Fan [Fri, 21 Feb 2014 10:00:29 +0000 (18:00 +0800)]
Make Visual Studio Build Process A Bit Simpler
Add some flexibility in the property sheets for one building GTK+ that it
also searches for a settable installation path of Python, in addition to
searching the PATH for an installation of the Python interpretor. This
currently defaults to Python 2.7.x, which is normally installed in
c:\python27 on Windows by default. Also tell people in the README.txt's
for the Visual Studio builds
Matthias Clasen [Thu, 20 Feb 2014 23:31:10 +0000 (18:31 -0500)]
GtkTooltip: Avoid extra work
When we are hiding the label or icon anyway, no need to change
it right before, causing reallocation overhead.
William Jon McCann [Thu, 20 Feb 2014 21:41:15 +0000 (16:41 -0500)]
Don't leak list items of popovers
William Jon McCann [Thu, 20 Feb 2014 20:44:47 +0000 (15:44 -0500)]
file-chooser: make accept action sensitive only when has selection
https://bugzilla.gnome.org/show_bug.cgi?id=547988
William Jon McCann [Thu, 20 Feb 2014 19:04:18 +0000 (14:04 -0500)]
docs: update the screenshots
From the doc shooter.
Jasper St. Pierre [Thu, 20 Feb 2014 17:38:32 +0000 (12:38 -0500)]
window: Fix configure request debug code in move_resize
Make it compile in GTK+3 and switch pos_changed / size_changed
to be the right way around.
Carlos Garnacho [Thu, 20 Feb 2014 15:24:59 +0000 (16:24 +0100)]
popover: Always apply the window shape
In practice this shape is only used to outline the popover when it is
above native windows, in the most normal full-csw case the shape won't apply
visibly, so popovers will still be able to cast a shadow there.
If there are native windows below the popover, the shape will exclude the
shadow, so there are no alpha contents above the window. One worst case that
might happen is that the popover lays above patches of native/client-side
windows, so the shadow could come and go around the border. But first let's
see whether that happens often or visibly enough before adding something more
convoluted.
Matthias Clasen [Thu, 20 Feb 2014 15:10:34 +0000 (10:10 -0500)]
Trivial annotation syntax fix
William Jon McCann [Thu, 20 Feb 2014 14:19:31 +0000 (09:19 -0500)]
print-dialog: remove shadow in from some of the tabs
Benjamin Otte [Thu, 20 Feb 2014 00:47:21 +0000 (01:47 +0100)]
reftests: Add a reftest for the latest fix
https://bugzilla.gnome.org/show_bug.cgi?id=724742
Benjamin Otte [Wed, 19 Feb 2014 20:15:25 +0000 (21:15 +0100)]
revealer: Allocate extra size to child
Do not constrain the child widget to its preferred size when the
revealer is larger.
https://bugzilla.gnome.org/show_bug.cgi?id=724742
Benjamin Otte [Tue, 18 Feb 2014 12:56:26 +0000 (13:56 +0100)]
stackswitcher: Don't do unneeded update
The update of the needs-attention state is done via its own property,
so it doesn't need to be done via visibility changes.
This patch is largely the result of inspecting the code due to a warning
and not a result of testing. So if issues pop up that bisect back to
this patch, that's why.
Benjamin Otte [Thu, 20 Feb 2014 01:08:53 +0000 (02:08 +0100)]
stylecascade: Remove function
Inline it.
Benjamin Otte [Thu, 20 Feb 2014 01:02:05 +0000 (02:02 +0100)]
settings: Store style cascade in settings object
This ensures that the initialization for the CSS theme happens when the
style cascade gets queried.
https://bugzilla.redhat.com/show_bug.cgi?id=
1064922
https://bugzilla.mozilla.org/show_bug.cgi?id=972382
Benjamin Otte [Tue, 18 Feb 2014 12:48:13 +0000 (13:48 +0100)]
testsuite: Add a test for a Firefox issue
When creating a style context, the CSS for the theme might not be
loaded. If it is, this test will succeed.
https://bugzilla.redhat.com/show_bug.cgi?id=
1064922
https://bugzilla.mozilla.org/show_bug.cgi?id=972382
Benjamin Otte [Fri, 14 Feb 2014 23:42:13 +0000 (00:42 +0100)]
tests: Connect signals in visuals test
This is useful for demoing animations.
Benjamin Otte [Fri, 14 Feb 2014 23:41:06 +0000 (00:41 +0100)]
tests: Don't use show_all() for a builder file
It's enough to gtk_widget_show() the window as all the widgets in a
builder file a marked properly for visibility.
Matthias Clasen [Thu, 20 Feb 2014 00:37:45 +0000 (19:37 -0500)]
docs: Improve section headings
Matthias Clasen [Thu, 20 Feb 2014 00:36:55 +0000 (19:36 -0500)]
Add docs
William Jon McCann [Wed, 19 Feb 2014 23:49:43 +0000 (18:49 -0500)]
docs: use Returns: consistently
Instead of Return value:
Kjartan Maraas [Wed, 19 Feb 2014 22:55:38 +0000 (23:55 +0100)]
Updated Norwegian bokmål translation
Yuri Myasoedov [Wed, 19 Feb 2014 17:28:25 +0000 (21:28 +0400)]
Fixed Russian translation
Matthias Clasen [Wed, 19 Feb 2014 07:03:51 +0000 (02:03 -0500)]
Bump version
Matthias Clasen [Wed, 19 Feb 2014 05:43:36 +0000 (00:43 -0500)]
3.11.7
Matthias Clasen [Wed, 19 Feb 2014 06:33:12 +0000 (01:33 -0500)]
GtkActionBar: Implement destroy
Similar to map/unmap, this needs to follow the actual
widget tree. Without this, several test cases in
the templates test fail.
Matthias Clasen [Wed, 19 Feb 2014 06:01:03 +0000 (01:01 -0500)]
Small documentation fixes
Matthias Clasen [Wed, 19 Feb 2014 06:00:09 +0000 (01:00 -0500)]
Drop unimplemented functions
These were added to the header by mistake in a recent commit.
They have no implementation, so dropping them won't cause
any harm.
Matthias Clasen [Wed, 19 Feb 2014 05:54:35 +0000 (00:54 -0500)]
Document gtk_header_bar_get_has_subtitle
Matthias Clasen [Wed, 19 Feb 2014 05:51:10 +0000 (00:51 -0500)]
Document gtk_widget_get_scale_factor
Matthias Clasen [Wed, 19 Feb 2014 05:31:40 +0000 (00:31 -0500)]
Fix a small memory leak
GtkPrintUnixDialog was leaking a GFile.
Spotted by Christian Persch in
https://bugzilla.gnome.org/show_bug.cgi?id=724631
Carlos Garnacho [Tue, 18 Feb 2014 13:38:30 +0000 (14:38 +0100)]
popover: Accept NULL relative_to widgets
And document the fact that the popover will get destroyed if
a NULL relative-to is given on a parented popover, if no extra
references are kept.
For gtk_popover_new*(), a NULL relative-to will leave the widget
as a floating object, to be sunk by a later call to
gtk_widget_set_relative_to().
https://bugzilla.gnome.org/show_bug.cgi?id=724407
Paolo Borelli [Sat, 15 Feb 2014 10:30:53 +0000 (11:30 +0100)]
Do not call popover_set_relative with NULL
This gives a critical warning since that function expects a
valid widget.
https://bugzilla.gnome.org/show_bug.cgi?id=724407
Matthias Clasen [Tue, 18 Feb 2014 03:27:35 +0000 (22:27 -0500)]
GtkTextHandle: Deal with parent_scrollable going away
Use a weak reference to notice when parent_scrollable is
going away.
https://bugzilla.gnome.org/show_bug.cgi?id=724392
Matthias Clasen [Wed, 19 Feb 2014 03:55:45 +0000 (22:55 -0500)]
GtkBox: Fix an off-by-one error with center allocation
This error was causing children to not get allocated when
the center widget is the first one in the list of the box's
children.
Matthias Clasen [Wed, 19 Feb 2014 02:16:35 +0000 (21:16 -0500)]
Make gtk_box_set_center_widget take NULL
It makes sense to allow this, and gtk_action_bar_set_center_widget
already assumes that it can pass NULL to this function.
Matthias Clasen [Wed, 19 Feb 2014 03:43:04 +0000 (22:43 -0500)]
Add map/unmap to GtkActionBar
The recursion in map needs to follow the actual physical
widget tree, otherwise we violate invariants. The generic
container map implementation uses gtk_container_forall to
operate on the children, and thus is not suitable for
containers where the children are inside some internal
container.
Matthias Clasen [Wed, 19 Feb 2014 02:11:32 +0000 (21:11 -0500)]
Fix up gtk_action_bar_forall
We need to always iterate over non-internal children.
Matthias Clasen [Wed, 19 Feb 2014 01:45:15 +0000 (20:45 -0500)]
Revert "action bar: remove the forall implementation"
This reverts commit
0ff0fdfefbba86f3dc7713cf55bbf00194274fe3.
Paolo Borelli [Tue, 18 Feb 2014 20:34:00 +0000 (21:34 +0100)]
Add a GtkFrame inside GtkActionBar
This is needed to set a padding and draw a border since GtkBox does
not honour css padding yet.
https://bugzilla.gnome.org/show_bug.cgi?id=724693
Jasper St. Pierre [Sun, 9 Feb 2014 16:31:54 +0000 (11:31 -0500)]
xdg-shell: Update for focused_set / focused_unset rename
Jasper St. Pierre [Sun, 16 Feb 2014 15:25:22 +0000 (10:25 -0500)]
wayland: Update to new xdg-shell pinging standards
Javier Jardón [Tue, 18 Feb 2014 15:18:51 +0000 (15:18 +0000)]
NEWS: Fix typo
Matthias Clasen [Tue, 18 Feb 2014 13:31:32 +0000 (08:31 -0500)]
Bump version
Ignacio Casal Quinteiro [Tue, 18 Feb 2014 10:42:45 +0000 (11:42 +0100)]
Remove duplicated word "id" from warning message
Matthias Clasen [Tue, 18 Feb 2014 05:50:09 +0000 (00:50 -0500)]
Updates
Matthias Clasen [Tue, 18 Feb 2014 04:55:53 +0000 (23:55 -0500)]
Make GtkSeparatorToolItem work for window-dragging again
This broke recently when the window dragging code was changed
to require motion events to be propagated as well.
https://bugzilla.gnome.org/show_bug.cgi?id=724539
Matthias Clasen [Tue, 18 Feb 2014 04:44:49 +0000 (23:44 -0500)]
gtk3-demo: set primary-toolbar style class on primary toolbars
This makes them draggable, and is the right thing to do.
Matthias Clasen [Tue, 18 Feb 2014 04:09:44 +0000 (23:09 -0500)]
GtkLabel: don't eat too many button release events
We should only eat button release events when the label is
actually selectable, since the comment indicates that we
want to eat the release events belonging to press events
that triggered a selection. This fixes problems with actions
on parent widgets that are triggered by button release,
as seen in this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=724541
Matthias Clasen [Tue, 18 Feb 2014 03:37:55 +0000 (22:37 -0500)]
Another trivial doc rewording
Matthias Clasen [Tue, 18 Feb 2014 03:30:58 +0000 (22:30 -0500)]
Trivial typo fix
Matthias Clasen [Tue, 18 Feb 2014 02:42:38 +0000 (21:42 -0500)]
Add some more templates tests
GtkActionBar and GtkSearchBar also use templates,
add them here.
Matthias Clasen [Tue, 18 Feb 2014 02:41:11 +0000 (21:41 -0500)]
tree view: clean up custom search entry on destroy
Suprisingly, this bug has been there for a very long time.
I'm fixing it now because we now use a custom search entry
in the app chooser dialog, and this is causing the templates
cleanup test to fail.
Matthias Clasen [Tue, 18 Feb 2014 02:40:36 +0000 (21:40 -0500)]
Make print dialog destruction work
This was also causing the templates test to fail.
Matthias Clasen [Tue, 18 Feb 2014 02:39:44 +0000 (21:39 -0500)]
action bar: remove the forall implementation
With nested internal children, this interferes with proper
cleanup, and makes the templates test fail.
Matthias Clasen [Tue, 18 Feb 2014 02:39:23 +0000 (21:39 -0500)]
Update expected output of the messagedialog a11y test
Matthias Clasen [Tue, 18 Feb 2014 02:39:10 +0000 (21:39 -0500)]
Update expected output of the colorchooser a11y test
Matthias Clasen [Mon, 17 Feb 2014 21:55:16 +0000 (16:55 -0500)]
Bump gtk-doc dep to 1.20
Paolo Borelli [Mon, 17 Feb 2014 22:19:10 +0000 (23:19 +0100)]
gtkbox: fix positioning of center widget
Yuri Myasoedov [Mon, 17 Feb 2014 17:15:29 +0000 (21:15 +0400)]
Fixed Russian translation
Matthias Clasen [Mon, 17 Feb 2014 16:54:43 +0000 (11:54 -0500)]
Fix return_if_fail lines in gtk_box_pack
Since the function now returns a value, these checks
need to be updated.